Skip to content

CLDSRV-870: Add support for bucket rate limiting API methods in bucket logging#6110

Merged
bert-e merged 2 commits intodevelopment/9.2from
improvement/CLDSRV-870
Mar 17, 2026
Merged

CLDSRV-870: Add support for bucket rate limiting API methods in bucket logging#6110
bert-e merged 2 commits intodevelopment/9.2from
improvement/CLDSRV-870

Conversation

@dvasilas
Copy link
Copy Markdown
Contributor

@dvasilas dvasilas commented Mar 16, 2026

Rate limit API methods were logged as REST.*.UNKNOWN because they were missing from the methodToResType mapping.

dvasilas added 2 commits March 16, 2026 10:45
@dvasilas
CLDSRV-870: Add rate limiting operations to access log mapping
7ddab07 
Rate limit API methods (put/get/delete) were logged as REST.*.UNKNOWN
because they were missing from the methodToResType mapping.
@dvasilas
CLDSRV-870: Bump version to 9.2.31
cc7c87f
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 16, 2026

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 16, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-870 contains:

  • 9.2.31

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.31

  • 9.3.6

  • 9.4.0

Please check the Fix Version/s of CLDSRV-870, or the target
branch of this pull request.

@claude
Copy link
Copy Markdown

claude bot commented Mar 16, 2026

LGTM

Review by Claude Code

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 16, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@dvasilas
Copy link
Copy Markdown
Contributor Author

dvasilas commented Mar 16, 2026

/create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 16, 2026

Conflict

A conflict has been raised during the creation of
integration branch w/9.3/improvement/CLDSRV-870 with contents from improvement/CLDSRV-870
and development/9.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.3/improvement/CLDSRV-870 origin/development/9.3
 git merge origin/improvement/CLDSRV-870
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.3/improvement/CLDSRV-870

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 16, 2026

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 16, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@dvasilas
Copy link
Copy Markdown
Contributor Author

dvasilas commented Mar 17, 2026

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 17, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.2

  • ✔️ development/9.3

  • ✔️ development/9.4

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1

Please check the status of the associated issue CLDSRV-870.

Goodbye dvasilas.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit cc7c87f into development/9.2 Mar 17, 2026
30 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-870 branch March 17, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anurag4DSB anurag4DSB anurag4DSB approved these changes

@leif-scality leif-scality leif-scality approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvasilas @bert-e @anurag4DSB @leif-scality